[pve-devel] applied: [PATCH qemu-server v3] Fix #2412: Missing VMs in pools

[Thomas Lamprecht]

On 10/15/19 12:17 PM, Dominic Jäger wrote:
> Between calling vm_destroy and removing the ID from user.cfg (remove_vm_access)
> creating a new VM with this ID was possible. VMs could go missing from pools as
> a consequence.
> 
> Adding a lock solves this for clones from the same node. Additionally,
> unlinking must happen at the very end of the deletion process to avoid that
> other nodes use the ID in the meanwhile.
> 
> Co-developed-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
> ---
> v1->v2: Move unlink to the end of the deletion process
> v2->v3: Use skiplock parameter and add error handling for unlink
> 
> I'll send a separate patch for the discussed clean up.
> 
>  PVE/API2/Qemu.pm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 

applied, thanks!