[pve-devel] [PATCH manager] ui: vm opts: clarify label for QGA

[Thomas Lamprecht]

On 10/10/19 12:31 PM, Aaron Lauterer wrote:
> 
> 
> On 10/10/19 12:21 PM, Dominik Csapak wrote:
>> On 10/10/19 11:54 AM, Thomas Lamprecht wrote:
>>> To make it more clear that PVE does not somehow magically injects a
>>> QHA into the VM, but that this can be set if one has installed the
>>> QGA in the VM themself.
>>
>> good idea to make it clearer, but i think the new text is also not ideal, since it does not describe what it does.
>>
>> maybe something like:
>>
>> 'Enable/Add Qemu Agent Hardware'

those still have the issue I'd like to avoid, i.e., suggesting
that we (PVE) add/enable it. It's not clear at all for the layman
user not knowing your distinction of "QGA Hardware" (== outside of VM)
vs. "QGA Daemon" (== inside of VM)

>> or
>> 'Query Qemu Agent' ?
>>
>> (altough i am not a big fan of those two either...)
> 
> What about:
> 
> 'Add support for Qemu Agent in VM'

same issue, IMO

> 'VM uses Qemu Agent'

meh

> 
> Though I do think Thomas' version is not bad.
> 
> Additionally we could add a hint if enabled saying something like this:
> 'Make sure the Qemu Agent is installed in the VM'
> 
> This would make it quite clear what is needed and enable us to keep a shorter checkbox label.
> 

IMO much better, then we could reword it to just "Use QEMU Guest Agent"
and show the hint if enabled. Makes it crystal clear, IMO :)