[pve-devel] [PATCH manager] ui: vm opts: clarify label for QGA

[Dominik Csapak]

On 10/10/19 11:54 AM, Thomas Lamprecht wrote:
> To make it more clear that PVE does not somehow magically injects a
> QHA into the VM, but that this can be set if one has installed the
> QGA in the VM themself.

good idea to make it clearer, but i think the new text is also not 
ideal, since it does not describe what it does.

maybe something like:

'Enable/Add Qemu Agent Hardware'
or
'Query Qemu Agent' ?

(altough i am not a big fan of those two either...)

> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>   www/manager6/form/AgentFeatureSelector.js | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index d50b709e..af14d1fe 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -7,7 +7,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>       items: [
>   	{
>   	    xtype: 'proxmoxcheckbox',
> -	    boxLabel: gettext('Qemu Agent'),
> +	    boxLabel: gettext('VM has Qemu Agent installed'),
>   	    name: 'enabled',
>   	    reference: 'enabled',
>   	    uncheckedValue: 0,
> @@ -29,8 +29,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>       },
>   
>       setValues: function(values) {
> -	var agent = values.agent || '';
> -	var res = PVE.Parser.parsePropertyString(agent, 'enabled');
> +	let res = PVE.Parser.parsePropertyString(values.agent, 'enabled');
>   	this.callParent([res]);
>       }
>   });
>