[pve-devel] applied: [PATCH v4 manager 1/3] Make CPU Model Selector a searchable grid view

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 2 16:19:46 CEST 2019


On 9/10/19 7:11 PM, Stefan Reiter wrote:
> Uses a ComboGrid with search feature and a column for vendor. Can be
> sorted by both columns.
> 
> Default sort is as given in this file, I tried to align it as
> * AMD
> * Intel
> * Other
> alphabetically and in QEMU order (as before, seems to be release date?)
> within those "groups".
> 
> Doesn't work with value set in widget definition (would need to be
> preferredValue), but we always call setValue() anyway (and if we don't,
> value will be '', aka the default, which is correct too), so just remove
> that from ProcessorEdit.js.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  www/manager6/form/CPUModelSelector.js | 193 +++++++++++++++++++++-----
>  www/manager6/qemu/ProcessorEdit.js    |   1 -
>  2 files changed, 159 insertions(+), 35 deletions(-)
> 

applied with solving the trivial merge conflict from Alexandre's recent
model additions[0].

Also did a follow up which changed the kvm{32,64} qemu{32,64} vendors
from Other to QEMU and the one from host to Host.
thanks!

[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/039228.html




More information about the pve-devel mailing list