[pve-devel] [PATCH v2 container 15/18] add revert parameter to config PUT

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 2 12:38:20 CEST 2019


On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>  src/PVE/API2/LXC/Config.pm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
> index 7eaef74..2c036f5 100644
> --- a/src/PVE/API2/LXC/Config.pm
> +++ b/src/PVE/API2/LXC/Config.pm
> @@ -102,6 +102,11 @@ __PACKAGE__->register_method({
>  		    description => "A list of settings you want to delete.",
>  		    optional => 1,
>  		},
> +		revert => {
> +		    type => 'string', format => 'pve-configid-list',
> +		    description => "Revert a pending change.",
> +		    optional => 1,
> +		},
>  		digest => {
>  		    type => 'string',
>  		    description => 'Prevent changes if current configuration file has different SHA1 digest. This can be used to prevent concurrent modifications.',
> 

does nothing here, and no rationale why this works now (if it worked) or
when (in a future patch, or?) this will work or do something at all, in the
commit message...

I'd squash it in 16/18 or at least order it after it..




More information about the pve-devel mailing list