[pve-devel] [RFC cluster 0/6] initial API adaption to corosync 3

[Fabian Grünbichler]

On Tue, May 28, 2019 at 06:33:07PM +0200, Thomas Lamprecht wrote:
> Allow to use new links, add compatibillity for configuration files using the
> new corosync 3 only properties, adapt create and join API to it, ...
> 
> This is only the API part, I'd like to have feedback regarding about the
> general direction this series moves things, mainly parameter wise.
> If we have some sort of agreement the WebUI should be adapted pretty easily.
> 
> I tried to split it up in a manner potential reviewer seem to prefer, I hope I
> succeeded at least somewhat, @Fabian ;)

some comments on the individual patches, general direction looks good to
me, I'll give v2 a more in-depth spin and not just read-only review!

> Tested creation and join through API with the pvecm CLI tool.
> 
> Thomas Lamprecht (6):
>   corosync config: support 'linknumber' property
>   add new corosync-link format
>   cluster create: use new corosync-link format for totem interfaces
>   corosync: allow to set link priorities
>   node join: use new corosync link parameters
>   remove now unused old corosync ringX_addr formats
> 
>  data/PVE/API2/ClusterConfig.pm | 77 +++++++++++++---------------------
>  data/PVE/CLI/pvecm.pm          | 15 ++++---
>  data/PVE/Cluster.pm            | 55 ++++++++++++++++++++----
>  data/PVE/Corosync.pm           | 61 +++++++++++++++++----------
>  4 files changed, 125 insertions(+), 83 deletions(-)
> 
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel