[pve-devel] [PATCH storage 0/1] Fix for ZFS over iSCSI on Solaris 11

[Dominik Csapak]

On 5/15/19 5:19 PM, David Hedbor wrote:
> I'm testing out ZFS over iSCSI with a Oracle Solaris 11.3 server
> (Sparc based specifically). It almost works - what doesn't work is
> when I try to act on the disk in any way (such as start
> KVM). Specifically it is unable to find the LUN.
> 
> Looking at the source, it seems like Proxmox runs:
> 
>      stmfadm list-view -l <guid>
> 
> to get the LUN. However on Solaris 11.3 (at least my installation),
> this returns the following:
> 
> View Entry: 0
>      Host group   : All
>      Target Group : All
>      LUN          : Auto
> 
> There's no LUN listed here. You can find ones assigned if you use the -v flag:
> 
> $ sudo stmfadm list-view -l 600144f2a8fee54fcb4fb8583c6d11dd -v
> View Entry: 0
>      Host group   : All
>      Target Group : All
>      LUN          : Auto
>          Lun      : 1    for iqn.1993-08.org.debian:01:e06b5e9eb438
>          Lun      : 1    for iqn.1993-08.org.debian:01:7c967782bc4
>          Lun      : 1    for iqn.1993-08.org.debian:01:dc213f1eceab
>          Lun      : 1    for iqn.1993-08.org.debian:01:8ee9e0466ec5
> 
> I modified Comstar.pm to handle this, which I assume is a change from
> Solaris 10 (OpenSolaris) to Solaris 11. I'm not happy with the copy of
> get_initiator_name - it's also used by QemuServer.pm. I'm not familar
> enough to know where to best place it.
> 
> David Hedbor (1):
>    storage: iscsi: Fix LunCmd for Comstar on Oracle Solaris 11
> 
>   PVE/Storage/LunCmd/Comstar.pm | 31 ++++++++++++++++++++++++++-----
>   1 file changed, 26 insertions(+), 5 deletions(-)
> 

hi,

first thanks for the patches :)

first i looked at omnios (current release) and there
'stmfadm list-view' has no '-v' argument and fails

as i know that at least the original author uses omnios with this,
i do not want to break it, or what is your stand on this @mir ?

it would probably ok to try and detect the solaris version (how?)
and only do this if it supports those options

as for get_initiator_name, we could probably put this into pve-common,
it seems general enough, then we could access it from qemu-server and
pve-storage