[pve-devel] [PATCH manager 2/2] fix #1451: add more mount options to containers in gui

Oguz Bektas o.bektas at proxmox.com
Wed May 15 18:15:41 CEST 2019


adds atime related options (noatime, nodiratime, relatime,
strictatime) and other extra mount options for performance (nobarrier)  and
security (noexec, nosuid, nodev).

Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
---

i tried to group the options by security or performance relation. the
placement is open to change, if we can find a better way to put all
this on the mp create/edit window.

 www/manager6/lxc/MPEdit.js | 75 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 59 insertions(+), 16 deletions(-)

diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index c7c3870a..3416d7eb 100644
--- a/www/manager6/lxc/MPEdit.js
+++ b/www/manager6/lxc/MPEdit.js
@@ -233,20 +233,6 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
     advancedColumn1: [
 	{
 	    xtype: 'proxmoxcheckbox',
-	    name: 'quota',
-	    defaultValue: 0,
-	    bind: {
-		disabled: '{!quota}'
-	    },
-	    fieldLabel: gettext('Enable quota'),
-	    listeners: {
-		disable: function() {
-		    this.reset();
-		}
-	    }
-	},
-	{
-	    xtype: 'proxmoxcheckbox',
 	    name: 'ro',
 	    defaultValue: 0,
 	    bind: {
@@ -254,7 +240,27 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
 		disabled: '{isRoot}'
 	    },
 	    fieldLabel: gettext('Read-only')
-	}
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'noexec',
+	    defaultValue: 0,
+	    fieldLabel: gettext('noexec')
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'nodev',
+	    defaultValue: 0,
+	    fieldLabel: gettext('nodev')
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'nosuid',
+	    defaultValue: 0,
+	    fieldLabel: gettext('nosuid')
+	},
+
+
     ],
 
     advancedColumn2: [
@@ -275,11 +281,48 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
 	    allowBlank: true
 	},
 	{
+	    xtype: 'proxmoxKVComboBox',
+	    name: 'atime',
+	    fieldLabel: 'atime',
+	    deleteEmpty: false,
+	    comboItems: [
+		['__default__', Proxmox.Utils.defaultText],
+		['noatime', 'noatime'],
+		['nodiratime', 'nodiratime'],
+		['relatime', 'relatime'],
+		['strictatime', 'strictatime'],
+	    ],
+	    value: '__default__',
+	    allowBlank: true
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'quota',
+	    defaultValue: 0,
+	    bind: {
+		disabled: '{!quota}'
+	    },
+	    fieldLabel: gettext('Enable quota'),
+	    listeners: {
+		disable: function() {
+		    this.reset();
+		}
+	    }
+	},
+	{
 	    xtype: 'proxmoxcheckbox',
 	    inputValue: '0', // reverses the logic
 	    name: 'replicate',
 	    fieldLabel: gettext('Skip replication')
-	}
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'nobarrier',
+	    defaultValue: 0,
+	    fieldLabel: gettext('nobarrier')
+	},
+
+
     ]
 });
 
-- 
2.11.0





More information about the pve-devel mailing list