[pve-devel] applied: [PATCH manager] ui: NodeSelector: check status field for offline nodes

[Thomas Lamprecht]

On 5/10/19 9:31 AM, Dominik Csapak wrote:
> On 5/9/19 6:32 PM, Thomas Lamprecht wrote:
>> On 5/8/19 11:12 AM, Dominik Csapak wrote:
>>> the memory stat is not available if the user has no audit privilges on
>>> /nodes/NODENAME but the status is always available
>>
>> but couldn't it be argued that this is desired behaviour?
>> Or is it out of consistency, as the node shows up all elsewhere or?
>>
> 
> 
> no the problem is actually that a user that is a PVEVMAdmin on some vm can see the nodes (required for most of the operations), but creating a new one or migration fails in the gui with 'node appears to be offline' when he can already see their status
> 
> so we should not prevent that in the gui since the api does not need that privilege for those operations


thanks for clarifying, applied!