[pve-devel] [PATCH ifupdown2 2/3] fix ipforwarding

[Thomas Lamprecht]

On 5/9/19 7:56 AM, Alexandre DERUMIER wrote:
>> We need to keep classic ifupdown behaviour 
> 
>>> is there any upstream issue/discussion regarding this? 
> 
> yes (I'm always trying to push upstream)

perfect! sorry for being to lazy to look for myself... :-)

> 
> https://github.com/CumulusNetworks/ifupdown2/issues/98
> 
> and PR
> https://github.com/CumulusNetworks/ifupdown2/pull/101
> 
> 
> 
> ----- Mail original -----
> De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
> À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
> Envoyé: Mercredi 8 Mai 2019 14:28:44
> Objet: Re: [pve-devel] [PATCH ifupdown2 2/3] fix ipforwarding
> 
> On 5/6/19 6:25 AM, Alexandre Derumier wrote: 
>> Currently ifupdown2 disable forwarding if not defined with ip-forward 
>> on interfaces, or if bridge don't have an address (breaking inet dhcp) 
>>
>> We need to keep classic ifupdown behaviour 
> 
> is there any upstream issue/discussion regarding this? 
> 
>>
>> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
>> --- 
>> ...e-ipforward-interface-value-if-not-define.patch | 100 +++++++++++++++++++++ 
>> ...autoconfiguration-of-forwarding-of-bridge.patch | 31 +++++++ 
>> debian/patches/series | 2 + 
>> 3 files changed, 133 insertions(+) 
>> create mode 100644 debian/patches/pve/0006-don-t-change-ipforward-interface-value-if-not-define.patch 
>> create mode 100644 debian/patches/pve/0007-disable-autoconfiguration-of-forwarding-of-bridge.patch 
>>
>> diff --git a/debian/patches/pve/0006-don-t-change-ipforward-interface-value-if-not-define.patch b/debian/patches/pve/0006-don-t-change-ipforward-interface-value-if-not-define.patch 
>> new file mode 100644 
>> index 0000000..facd462 
>> --- /dev/null 
>> +++ b/debian/patches/pve/0006-don-t-change-ipforward-interface-value-if-not-define.patch 
>> @@ -0,0 +1,100 @@ 
>> +From 053252ec9cc5f60db1cdcb44800690708bb9c11b Mon Sep 17 00:00:00 2001 
>> +From: Alexandre Derumier <aderumier at odiso.com> 
>> +Date: Mon, 6 May 2019 06:04:48 +0200 
>> +Subject: [PATCH] don't change ipforward interface value if not defined 
>> + 
>> +Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
>> +--- 
>> + ifupdown2/addons/address.py | 73 ++++++++++++++++++++------------------------- 
>> + 1 file changed, 33 insertions(+), 40 deletions(-) 
>> + 
>> +diff --git a/ifupdown2/addons/address.py b/ifupdown2/addons/address.py 
>> +index d3a76cf..a2f86f3 100644 
>> +--- a/ifupdown2/addons/address.py 
>> ++++ b/ifupdown2/addons/address.py 
>> +@@ -715,49 +715,42 @@ class address(moduleBase): 
>> + self.log_error('%s: \'ip6-forward\' is not supported for ' 
>> + 'bridge port' %ifaceobj.name) 
>> + return 
>> +- setting_default_value = False 
>> +- if not ipforward: 
>> +- setting_default_value = True 
>> +- ipforward = (self.ipforward or 
>> +- self.get_mod_subattr('ip-forward', 'default')) 
> 
> why not just change the default? I.e., 
> 
> ----8<---- 
> diff --git a/ifupdown2/addons/address.py b/ifupdown2/addons/address.py 
> index d3a76cf..96afcb6 100644 
> --- a/ifupdown2/addons/address.py 
> +++ b/ifupdown2/addons/address.py 
> @@ -99,12 +99,12 @@ class address(moduleBase): 
> 'ip-forward' : 
> { 'help': 'ip forwarding flag', 
> 'validvals': ['on', 'off', 'yes', 'no', '0', '1'], 
> - 'default' : 'off', 
> + 'default' : 'on', 
> 'example' : ['ip-forward off']}, 
> 'ip6-forward' : 
> { 'help': 'ipv6 forwarding flag', 
> 'validvals': ['on', 'off', 'yes', 'no', '0', '1'], 
> - 'default' : 'off', 
> + 'default' : 'on', 
> 'example' : ['ip6-forward off']}, 
> 'mpls-enable' : 
> { 'help': 'mpls enable flag', 
>