[pve-devel] [PATCH qemu-server 5/7] add todo comment for bwlimits in clone_disk

Stoiko Ivanov s.ivanov at proxmox.com
Fri Mar 29 08:28:04 CET 2019


clone_disk calls `qemu-img convert` for offline disks, which does not have a
bandwidth limit parameter.

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 PVE/QemuServer.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b8e96ed..e225cb6 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6940,6 +6940,7 @@ sub clone_disk {
 
 	my $sparseinit = PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $newvolid);
 	if (!$running || $snapname) {
+	    #TODO: handle bwlimits
 	    qemu_img_convert($drive->{file}, $newvolid, $size, $snapname, $sparseinit);
 	} else {
 
-- 
2.11.0




More information about the pve-devel mailing list