[pve-devel] applied: [PATCH manager v2 0/8] add system tab in wizard

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Mar 28 17:56:27 CET 2019


On 3/28/19 4:25 PM, Dominik Csapak wrote:
> this series adds a new tab in the vm wizard: system
> 
> it is used to configure the system hardware of a vm (like scsihw)
> also moves/adds some options to the hardwareview from the options
> 
> the icons i chose are only my suggestion, if someone has a better
> idea for them, please share it :)
> 
> changes from v1:
> * adds a efidisk creation under the bios selector
> * fixed an issue with binding in the HDEdit inputpanel
> * fixes an typo (insideWizard)
> 
> Dominik Csapak (8):
>   gui: qemu/HardwareView: prepare Hardwareview for font-awesome icons
>   gui: DiskStorageSelector: implement disabling
>   gui: add qemu/SystemEdit
>   gui: add system panel to the vm creation wizard
>   gui: qemu/HardwareView: add space between groups
>   gui: qemu/HardwareView: remove Keyboard setting
>   gui: qemu/HardwareView: move scsihw and bios to HardwareView
>   gui: qemu/HardwareView: add machine to HardwareView
> 
>  www/css/ext6-pve.css                     |   8 ++
>  www/manager6/Makefile                    |   1 +
>  www/manager6/Utils.js                    |   4 +
>  www/manager6/form/DiskStorageSelector.js |  19 ++++
>  www/manager6/qemu/CreateWizard.js        |  19 ++--
>  www/manager6/qemu/HDEdit.js              |  11 +--
>  www/manager6/qemu/HardwareView.js        |  70 ++++++++++----
>  www/manager6/qemu/OSTypeEdit.js          |   3 +-
>  www/manager6/qemu/Options.js             |  12 ---
>  www/manager6/qemu/SystemEdit.js          | 156 +++++++++++++++++++++++++++++++
>  10 files changed, 257 insertions(+), 46 deletions(-)
>  create mode 100644 www/manager6/qemu/SystemEdit.js
> 

applied series, but had to add followup ensuring that the "add efi disk"
checkbox does not get submitted, it broke our schema verification of the
create POST call, always remember: last minute changes without fully testing
again are plain evil.. :)



More information about the pve-devel mailing list