[pve-devel] [PATCH manager v2 7/8] gui: qemu/HardwareView: move scsihw and bios to HardwareView

Dominik Csapak d.csapak at proxmox.com
Thu Mar 28 16:25:10 CET 2019


it is guest hardware and not really an option, and we have it now
in the wizard, so it makes sense to have it here

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/qemu/HardwareView.js | 23 +++++++++++++++++++----
 www/manager6/qemu/Options.js      | 12 ------------
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index acb0b4d8..3db466ee 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -127,15 +127,33 @@ Ext.define('PVE.qemu.HardwareView', {
 		    return res;
 		}
 	    },
+	    bios: {
+		header: 'BIOS',
+		group: 4,
+		never_delete: true,
+		editor: caps.vms['VM.Config.Options'] ? 'PVE.qemu.BiosEdit' : undefined,
+		defaultValue: '',
+		iconCls: 'microchip',
+		renderer: PVE.Utils.render_qemu_bios
+	    },
 	    vga: {
 		header: gettext('Display'),
 		editor: caps.vms['VM.Config.HWType'] ? 'PVE.qemu.DisplayEdit' : undefined,
 		never_delete: true,
 		tdCls: 'pve-itype-icon-display',
-		group:4,
+		group:5,
 		defaultValue: '',
 		renderer: PVE.Utils.render_kvm_vga_driver		
 	    },
+	    scsihw: {
+		header: gettext('SCSI Controller'),
+		iconCls: 'database',
+		editor: caps.vms['VM.Config.Options'] ? 'PVE.qemu.ScsiHwEdit' : undefined,
+		renderer: PVE.Utils.render_scsihw,
+		group: 7,
+		never_delete: true,
+		defaultValue: ''
+	    },
 	    cores: {
 		visible: false
 	    },
@@ -160,9 +178,6 @@ Ext.define('PVE.qemu.HardwareView', {
 	    cpulimit: {
 		visible: false
 	    },
-	    bios: {
-		visible: false
-	    },
 	    shares: {
 		visible: false
 	    }
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index d1fb5a1f..e1580060 100644
--- a/www/manager6/qemu/Options.js
+++ b/www/manager6/qemu/Options.js
@@ -174,18 +174,6 @@ Ext.define('PVE.qemu.Options', {
 		    }
 		} : undefined
 	    },
-	    scsihw: {
-		header: gettext('SCSI Controller'),
-		editor: caps.vms['VM.Config.Options'] ? 'PVE.qemu.ScsiHwEdit' : undefined,
-		renderer: PVE.Utils.render_scsihw,
-		defaultValue: ''
-	    },
-	    bios: {
-		header: 'BIOS',
-		editor: caps.vms['VM.Config.Options'] ? 'PVE.qemu.BiosEdit' : undefined,
-		renderer: PVE.Utils.render_qemu_bios,
-		defaultValue: ''
-	    },
 	    kvm: {
 		header: gettext('KVM hardware virtualization'),
 		defaultValue: true,
-- 
2.11.0




More information about the pve-devel mailing list