[pve-devel] [PATCH manager 0/7] add system tab in wizard

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Mar 27 17:12:10 CET 2019


On 3/27/19 2:13 PM, Dominik Csapak wrote:
> this series adds a new tab in the vm wizard: system
> 
> it is used to configure the system hardware of a vm (like scsihw)
> also moves/adds some options to the hardwareview from the options
> 
> the icons i chose are only my suggestion, if someone has a better
> idea for them, please share it :)
> 
> Dominik Csapak (7):
>   gui: qemu/HardwareView: prepare Hardwareview for font-awesome icons
>   gui: add qemu/SystemEdit
>   gui: add system panel to the vm creation wizard
>   gui: qemu/HardwareView: add space between groups
>   gui: qemu/HardwareView: remove Keyboard setting
>   gui: qemu/HardwareView: move scsihw and bios to HardwareView
>   gui: qemu/HardwareView: add machine to HardwareView
> 
>  www/css/ext6-pve.css              |  8 ++++
>  www/manager6/Makefile             |  1 +
>  www/manager6/Utils.js             |  4 ++
>  www/manager6/qemu/CreateWizard.js | 19 +++++----
>  www/manager6/qemu/HDEdit.js       | 10 ++---
>  www/manager6/qemu/HardwareView.js | 70 +++++++++++++++++++++++--------
>  www/manager6/qemu/OSTypeEdit.js   |  3 +-
>  www/manager6/qemu/Options.js      | 12 ------
>  www/manager6/qemu/SystemEdit.js   | 86 +++++++++++++++++++++++++++++++++++++++
>  9 files changed, 168 insertions(+), 45 deletions(-)
>  create mode 100644 www/manager6/qemu/SystemEdit.js
> 

looks nice in general! I almost applied it thinking that it could be improved later on
but after detecting the inisdeWizard typo by accident I didn't want to rush it and maybe
you can send a v2 with the typo, comment and efidisk wish addressed ;)



More information about the pve-devel mailing list