[pve-devel] [PATCH docs] Reword krbd option description

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 19 13:11:00 CET 2019


On 3/19/19 1:06 PM, Alwin Antreich wrote:
> On Tue, Mar 19, 2019 at 01:00:29PM +0100, Thomas Lamprecht wrote:
>> On 3/19/19 12:56 PM, Alwin Antreich wrote:
>>> Reword the description of the KRBD option to reflect its current use for
>>> VMs only. A container needs to use KRBD for a mapped device anyway and
>>> is not affected by this option.
>>>
>>> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
>>> ---
>>>  pve-storage-rbd.adoc | 3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/pve-storage-rbd.adoc b/pve-storage-rbd.adoc
>>> index ee07371..91165ca 100644
>>> --- a/pve-storage-rbd.adoc
>>> +++ b/pve-storage-rbd.adoc
>>> @@ -49,8 +49,7 @@ RBD user Id. Optional, only needed if Ceph is not running on the PVE cluster.
>>>  
>>>  krbd::
>>>  
>>> -Access rbd through krbd kernel module. This is required if you want to
>>> -use the storage for containers.
>>> +Access rbd through the krbd kernel module. Optional, applies to VMs only.
>>
>> suggest that with this set only VMs go through krdb, but CTs not (anymore)?
>>
>> maybe something like:
>>> Always access rbd through the krbd kernel module. Optional, container will
>>> always use krbd.
> I thought about adding a note below, but wanted to get comments firs. ;)
> 
> I would prefere a note box bellow the option to clarify that CTs need
> KRBD anway, but not set on this. Which one would you prefere?

I do not want the "applies to VMs only" part, you could remove it and add
a note below that CTs will always go through KRBD as long as the storage
is enabled to host CTs at all, that would be OK for me.

> 
>>
>> ?
>>
>>>  
>>>  .Configuration Example for a external Ceph cluster (`/etc/pve/storage.cfg`)
>>>  ----
>>>
>>




More information about the pve-devel mailing list