[pve-devel] [PATCH qemu-server 1/3] add correct comment about savevm-start

[Thomas Lamprecht]

On 3/19/19 9:17 AM, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/QemuConfig.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
> index b2d4e45..8fae4fc 100644
> --- a/PVE/QemuConfig.pm
> +++ b/PVE/QemuConfig.pm
> @@ -138,6 +138,10 @@ sub __snapshot_save_vmstate {
>      }
>  
>      my $driver_state_size = 500; # assume 500MB is enough to safe all driver state;
> +    # our savevm-start does live-save of the memory until the space left in the
> +    # volume is just enough for the remaining memory content + internal state
> +    # then it stops the vm and copies the rest so we reserve twice the
> +    # memory content + state to minimize vm downtime
>      my $size = $conf->{memory}*2 + $driver_state_size;
>      my $scfg = PVE::Storage::storage_config($storecfg, $target);
>  
> 

applied all three patches, thanks!

maybe it's worth to add some logic to make "qm resume ..." also work for " to disk
suspended" VMs, else it could be potentially a bit confusing for people.