[pve-devel] applied: [PATCH firmware] minimize skip list for current fw submodule version

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Wed Mar 13 11:09:58 CET 2019


On Tue, Mar 12, 2019 at 11:39:17AM +0100, Thomas Lamprecht wrote:
> As once added to the list we never check if it'd be available now we
> have some unnecessary entries in the skip list, which this patch
> cleans up. Produced by deleting all skip list entries and successive
> re-adding them by doing:
> ./assemble-firmware.pl fwlist-FILE /tmp) 2>&1 | awk '/unable/ { print $5 }' >> skip-cleanedup
> and adding only those which are now not found.
> 
> The "additions" come from those lines were previously multiple
> skipped fws were placed on a single one.
> 
> We could also add support for such checks in the assemble-firmware
> script, wouldn't be to hard, but for now do this as a starter.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>

applied, thanks. the skip list is only consulted if a firmware file is
not found, so this is a just a cosmetic cleanup anyway ;)



More information about the pve-devel mailing list