[pve-devel] [PATCH v7 manager 0/3] add pveceph install to gui

Tim Marx t.marx at proxmox.com
Wed Mar 6 12:29:37 CET 2019

Reworked the manager part including the suggestions from the review.
Meanwhile the series got partially applied, therefor v7 is now slimmer.
In general this revision adds some error handling, reloading for not
store based views and I factored out some code which is similar.

Now a wizard is available which guides through the installation and
afterwards, if needed, it will offer to init ceph config.
Therefore I added the cmd paramater to the inline console as well,
resulting in an additional commit.

Some minor things still need some polish e.g. inline terminal connection
errors after successfull installation and info text after installation.

I added the install window to the remaining submenus.
This needed some changes regarding error handling to get the same
behavior for all subviews.

Only the manager repo got touched.

I addressed various inputs:

I headed back to my original approach and declare the cmd parameter 
in each api endpoint separately. This results again in only 4 repos
touched instead of 5. This change is reasoned by Thomas input [0].
I decided against a module level variable because I think it improves
the readability.

All repos since v2 are untouched except the pve-manager.
Changed some commit messages slightly.

[0] https://pve.proxmox.com/pipermail/pve-devel/2019-January/035358.html

In general I changed the approach from passing a command directly to
passing a command keyword which gets matched in the api and not
directly executed. Only the following two out of now 5 (v1 were 4) repos 
got changed since v1.

With this patch series and the corresponding patches in the following repositories
its now possible to install ceph via the gui in the same way as someone would if using the
pveceph install command manually

Affected repositories:

  * altered the ceph install check to check for the mon binary, 
    because the ceph binary is likely to be there already
  * added parameter to all 3 consoles (novnc,xterm,spice) to pass a custom command
  * in the gui the ceph status page checks if the not install error returns and 
    if so, shows a window which offers to install ceph

  * added new cmd paramater 
  * added new cmd paramater
  * added new cmd paramater

Tim Marx (3):
  added new parameter to pass a command to the newly opened terminal
  add cmd parameter & rework query string creation
  added basic ability to install ceph via gui

 www/css/ext6-pve.css                   |   5 +
 www/manager6/Makefile                  |   3 +
 www/manager6/Utils.js                  |  78 +++++++++-
 www/manager6/VNCConsole.js             |  22 ++-
 www/manager6/button/ConsoleButton.js   |  12 +-
 www/manager6/ceph/CephInstallWizard.js | 267 +++++++++++++++++++++++++++++++++
 www/manager6/ceph/Config.js            |   9 ++
 www/manager6/ceph/Crush.js             |   8 +
 www/manager6/ceph/FS.js                |  24 ++-
 www/manager6/ceph/Log.js               |  60 ++++++++
 www/manager6/ceph/Monitor.js           |  13 +-
 www/manager6/ceph/OSD.js               |   9 +-
 www/manager6/ceph/Pool.js              |  12 +-
 www/manager6/ceph/Status.js            |  13 +-
 www/manager6/node/Config.js            |   5 +-
 www/manager6/window/CephInstall.js     |  66 ++++++++
 16 files changed, 578 insertions(+), 28 deletions(-)
 create mode 100644 www/manager6/ceph/CephInstallWizard.js
 create mode 100644 www/manager6/ceph/Log.js
 create mode 100644 www/manager6/window/CephInstall.js


More information about the pve-devel mailing list