[pve-devel] applied: [PATCH manager] add subscription panel on dc summary

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 5 14:26:05 CET 2019


On 3/5/19 2:21 PM, Dominik Csapak wrote:
> On 04/03/2019 12:10, Thomas Lamprecht wrote:
>> On 3/1/19 2:27 PM, Dominik Csapak wrote:
>>> So that the users have a good and fast feedback about ther
>>> support and subscripttion status, especially if they have
>>> mistakenly different levels of susbscriptions in their cluster.
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>>> ---
>>> this is modeled after the subscription panel in the pmg dashboard,
>>> but differently enough, so that a refactor would be more work than
>>> what we would gain
>>
>>
>> works good in general, but the duration between setting a subscription key
>> and having a valid state here seems to be a bit long, feels even longer than
>> the 3 seconds of update interval here, but maybe it seems just like this.
> 
> mhmm, there is nothing special here, as soon as we get the
> info from the cluster, we display it. maybe some caching is going on
> in the backend? (pvestatd?)

not sure, maybe just bad luck on testing.

> 
>>
>> Also I'm not sure about the wording, maybe instead of "You" we should say
>> "The cluster", to make it more clearer about what this is?
>> But if there not really better suggestions I can also apply this as is.
>>
> we use those in pmg, so we already have some translations for those gettexts
> 

ah okay, perfect! applied, thanks!



More information about the pve-devel mailing list