[pve-devel] applied: [PATCH v2 qemu-server 1/2] migrate: handle storage not selected manually in storage config

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 28 17:59:01 CEST 2019


On 6/28/19 3:13 PM, Tim Marx wrote:
> e.g. local storage was considered not allowed for offline migration
> even if it is available on all nodes, this should now be fixed as it
> is now considered available on all nodes if a local storage isn't
> restricted to a specific subset of the available nodes. The user is
> responseable to make sure that the datacenter storage config reflects
> the actual setup, so there is no additional check for local storages
> which aren't available on all nodes if they are not explicitly marked
> at datacenter level.
> 

applied, but not really happy with that all, or better said the current
state of those whole shared_nodes, check_local_storage_availability,
check_storage_availability methods wich are all similar, with subtle
differences, and all really fragile, IMO, just feels like there's a huge
pile of technical debt which this series even added to a bit... Tacking a
step back and cleaning this up would be really great, I'd guess that
we could remove almost a few 100 lines here..

Oh, i squashed into your manager patch, so pulling will bring issues to
you, really sorry about that, I originally wanted to do just a followup.




More information about the pve-devel mailing list