[pve-devel] [PATCH storage v2] Fix #582: Make removing backups a background task

[Dominic Jäger]

Thank you for the feedback!

On 6/28/19 12:22 PM, Thomas Lamprecht wrote:
> FYI, this API entry point is for _all_ content removal, not just backups...
> I.e., ISOs, disks, templates, backups, snippets..
> 
I really wasn't aware of that.
> 
> indentation error above
Fixed
> 
> 
> declaration should be in the vicinity of use, if possible
Fixed> in the volid we have still a few assumptions we can break with 
certain volids... (...)> So, maybe use $storeid and add $ownervm if defined?
> I mean, IMO, the $volid would be really best, as then one could have:
> "Erase 'tom-nasi:iso/alpine-standard-3.5.0_rc5-x86.iso'" int the task log
> description, which tells a user much more than just "Erase data"..
As I don't know those assumptions off the top of my head, I'm not really 
sure which option to choose at the moment, but I will have a look at it!
> Also please add a
>> print "Removed volume '$volid'\n";
> line after the free (...)
Fixed
> 
> 
> Also the web gui part where the background_delay is passed misses still.
> While we'd have this logic available in our proxmox edit window class the
> parts where it needs to be used are not users of that class, so we may want
> to add some functionallity to std remove button, possibly..
I will add this in the next version.