[pve-devel] [PATCH manager 1/2] 5to6: add check for running kernel version

[Fabian Grünbichler]

> Thomas Lamprecht <t.lamprecht at proxmox.com> hat am 27. Juni 2019 21:59 geschrieben:
> 
>  
> On 6/27/19 9:02 PM, Fabian Grünbichler wrote:
> > Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> > ---
> >  PVE/CLI/pve5to6.pm | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
> > index 94535776..98b35594 100644
> > --- a/PVE/CLI/pve5to6.pm
> > +++ b/PVE/CLI/pve5to6.pm
> > @@ -129,6 +129,15 @@ sub check_pve_packages {
> >  	} else {
> >  	    log_fail("proxmox-ve package is too old, please upgrade to >= $min_pve_ver!");
> >  	}
> > +	print "\nChecking running kernel version..\n";
> > +	my $kernel_ver = $proxmox_ve->{RunningKernel};
> > +	if (!defined($kernel_ver)) {
> > +	    log_fail("unable to determine running kernel version.");
> > +	} elsif ($kernel_ver =~ /^5\./) {
> > +	    log_pass("expected running kernel '$kernel_ver'.");
> > +	} else {
> > +	    log_warn("unexpected running kernel '$kernel_ver'.");
> > +	}
> >      }
> >  }
> >  
> > 
> 
> until now I just applied all commits to this on both master and
> stable-5, but this is intended to only go to master, AFAICT?
> 
> 
> I mean we can differ, but I'd avoid that if possible, as it then
> makes applying common stuff again harder (conflicts)..
> 
> We could add global variable which defines if we're on 5 or 6 and
> use that in such checks. E.g., here to see if we should check 4.15
> or 5.0 ?
> 
> At least else I could imagine that this warning is possible a bit
> confusing to some people if they get it on 5.4 on the first run...

yes, these were intended for master only, but checking the running kernel for 5.4 is of course also possible..