[pve-devel] [PATCH RFC ceph/pve-manager] remove obsolete ceph.service

Fabian Grünbichler f.gruenbichler at proxmox.com
Thu Jun 27 15:59:44 CEST 2019


> Dominik Csapak <d.csapak at proxmox.com> hat am 27. Juni 2019 14:51 geschrieben:
> 
>  
> this series removes the not needed ceph.service
> since in nautilus there is no ceph-disk anymore
> 
> we delete/disable the existing ceph.service in the ceph.osd postinst
> trigger, since this is the right place to check for this since
> 1) it only make sense for nodes with osds
> 2) is the place where we can know that we install ceph nautilus over luminous
>    (it is irrelevant for fresh nautilus clusters)

removal could also be handled manually via the checklist/upgrade notes, but if we do this approach, we should also have appropriate breaks from ceph to pve-manager versions that still ship/install ceph.service.. we also probably want to guard the automatic removal with a hashsum check, otherwise ceph.service might be something custom installed by the admin and not the one installed by pveceph..

> 
> ceph:
> 
> Dominik Csapak (1):
>   add postinst code to remove old ceph osd activation script
> 
>  ...e-ceph-osd-activation-script-in-post.patch | 39 +++++++++++++++++++
>  patches/series                                |  1 +
>  2 files changed, 40 insertions(+)
>  create mode 100644 patches/0009-remove-legacy-pve-ceph-osd-activation-script-in-post.patch
> 
> pve-manager:
> 
> Dominik Csapak (1):
>   ceph: remove obsolete ceph.service and do not distribute it anymore
> 
>  PVE/CLI/pveceph.pm          | 14 --------------
>  services/Makefile           |  1 -
>  services/ceph.service       | 11 -----------
>  services/pve-storage.target |  2 +-
>  4 files changed, 1 insertion(+), 27 deletions(-)
>  delete mode 100644 services/ceph.service
> 
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list