[pve-devel] [RFC manager 2/2] upgrade checklist

[Thomas Lamprecht]

On 6/24/19 1:56 PM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> Notes:
>     leftout on purpose:
>     - checking of sources.list (no parser, lots of false negatives, needs to happen after upgrade to corosync 3)
>     
>     still missing for PVE 6.x / post-upgrade version:
>     - modification of checked versions
>     - ceph-volume scan on managed nodes with OSDs
>     
>     still missing for PVE 6.x / post-reboot version:
>     - check for running kernel
>     
>     suggestions for additional checks/adaptations very welcome!
> 
>     to actually install and test, the usual build cycle with pve-docs needs to
>     be manually broken. alternatively, manual copying/execution works fine as
>     well ;)
> 
>  PVE/CLI/Makefile   |   2 +-
>  bin/Makefile       |   3 +-
>  PVE/CLI/pve5to6.pm | 370 +++++++++++++++++++++++++++++++++++++++++++++
>  bin/pve5to6        |  10 ++
>  4 files changed, 383 insertions(+), 2 deletions(-)
>  create mode 100644 PVE/CLI/pve5to6.pm
>  create mode 100755 bin/pve5to6
> 
> diff --git a/PVE/CLI/Makefile b/PVE/CLI/Makefile
> index 93b3f3c6..7e9ae0df 100644
> --- a/PVE/CLI/Makefile
> +++ b/PVE/CLI/Makefile
> @@ -1,6 +1,6 @@
>  include ../../defines.mk
>  
> -SOURCES=vzdump.pm pvesubscription.pm pveceph.pm pveam.pm pvesr.pm pvenode.pm pvesh.pm
> +SOURCES=vzdump.pm pvesubscription.pm pveceph.pm pveam.pm pvesr.pm pvenode.pm pvesh.pm pve5to6.pm
>  
>  all:
>  
> diff --git a/bin/Makefile b/bin/Makefile
> index 52044ca9..31229477 100644
> --- a/bin/Makefile
> +++ b/bin/Makefile
> @@ -7,7 +7,7 @@ PERL_DOC_INC_DIRS=..
>  include /usr/share/pve-doc-generator/pve-doc-generator.mk
>  
>  SERVICES = pvestatd pveproxy pvedaemon spiceproxy
> -CLITOOLS = vzdump pvesubscription pveceph pveam pvesr pvenode pvesh
> +CLITOOLS = vzdump pvesubscription pveceph pveam pvesr pvenode pvesh pve5to6
>  
>  SCRIPTS =  			\
>  	${SERVICES}		\
> @@ -48,6 +48,7 @@ all: ${SERVICE_MANS} ${CLI_MANS} pvemailforward
>  	podselect $* > $@.tmp
>  	mv $@.tmp $@
>  
> +pve5to6.1.pod: pve5to6

above makes no sense?? This has no POD included so podselect won't find anything,
that's not bootstrapping pve-docs issue that's just wrong..

>  pveversion.1.pod: pveversion
>  pveupgrade.1.pod: pveupgrade
>  pvereport.1.pod: pvereport


> diff --git a/bin/pve5to6 b/bin/pve5to6
> new file mode 100755
> index 00000000..4802e185
> --- /dev/null
> +++ b/bin/pve5to6
> @@ -0,0 +1,10 @@
> +#!/usr/bin/perl -T

why a tainted switch?

> +
> +use strict;
> +use warnings;
> +
> +use lib qw(.);

why this as lib? one needs to call it with bin/pve5to6 then, at least locally,
for such stuff just use "perl -I. bin/..", so the source don't needs to be touched
(and then potentially distributed in this way, I mean the lib is now always the CWD
from which this gets called!)

> +
> +use PVE::CLI::pve5to6;
> +
> +PVE::CLI::pve5to6->run_cli_handler();
>