[pve-devel] applied: [PATCH v2 widget-toolkit 1/1] refactor info/link extraction from onlinehelp to utils

[Thomas Lamprecht]

Am 6/21/19 um 3:25 PM schrieb Dominik Csapak:
> On 6/21/19 3:18 PM, Thomas Lamprecht wrote:
>> Am 6/21/19 um 12:03 PM schrieb Dominik Csapak:
>>> so that we can reuse that code for getting links from the docs
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>>> ---
>>> new in v2
>>
>> applied, small comment - independent of your change - inline.
>>
>>>   Utils.js             | 23 +++++++++++++++++++++++
>>>   button/HelpButton.js | 21 ++-------------------
>>>   2 files changed, 25 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/Utils.js b/Utils.js
>>> index 645c525..ee0a0ce 100644
>>> --- a/Utils.js
>>> +++ b/Utils.js
>>> @@ -593,6 +593,29 @@ Ext.define('Proxmox.Utils', { utilities: {
>>>       return Ext.Date.format(servertime, 'Y-m-d H:i:s');
>>>       },
>>>   +    get_help_info: function(section) {
>>> +    var helpMap;
>>> +    if (typeof proxmoxOnlineHelpInfo !== 'undefined') {
>>> +        helpMap = proxmoxOnlineHelpInfo;
>>> +    } else if (typeof pveOnlineHelpInfo !== 'undefined') {
>>> +        // be backward compatible with older pve-doc-generators
>>> +        helpMap = pveOnlineHelpInfo;
>>
>> above can now be probably dropped safely.
>>
> 
> no sadly we haven't switched from pveOnlineHelpInfo to proxmoxOnlineHelpInfo
> yet, as ascidoc-pve.in still generates pveOnlineHelpInfo
> (i do not know why nor how the change was planned)
> 
> 

argh, OK, I mean this is not to bad in general, we can just keep the small
branch a be OK. Else, I'd propose to make it switch now so that we can remove
it still for PVE 6