[pve-devel] [PATCH v2 storage 1/2] fix #2226: ignore broken symlinks in *_list

Stefan Reiter s.reiter at proxmox.com
Mon Jun 17 11:05:31 CEST 2019


Broken symlinks (and other files without a size) will now show up as 0
byte instead of causing a format validation error in the API.

Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
---
 PVE/Storage.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 588e775..0ce942a 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -800,7 +800,7 @@ sub snippets_list {
 		push @{$res->{$sid}}, {
 		    volid => "$sid:snippets/". basename($fn),
 		    format => 'snippet',
-		    size => -s $fn,
+		    size => -s $fn // 0,
 		};
 	    }
 	}
@@ -867,7 +867,7 @@ sub template_list {
 		    $info = { volid => "$sid:backup/$1", format => $2 };
 		}
 
-		$info->{size} = -s $fn;
+		$info->{size} = -s $fn // 0;
 
 		push @{$res->{$sid}}, $info;
 	    }
-- 
2.20.1





More information about the pve-devel mailing list