[pve-devel] applied: [PATCH pve-manager 0/4] network api : reload : cleanup

[Alexandre DERUMIER]

>>Regarding the OVS stuff, does the checks needs to be that "hard", i.e.,
>>couldn't I have OVS installed but unused?
>>But it's an easy and cheapo check so for now definitively OK for me.. 

I could check if current running config is empty with ovs-vsctl.
but if user add ovs config /etc/network/interfaces.new, I need to parse it.


I'll do test next week with ovs, to see the behaviour on ifupdown2 reload.
(I have done test last year, but don't remember if it's removing the ovs interfaces, or ifdown/up,...)


>>I'll try to bump and move the current set of packages out on pvetest 
>>during start of next week, FYI, should make it a bit easier again - 
>>and no need to bootstrap anymore :) 
Thanks !
(I'll resent patches for sdn api endpoint in pve-cluster and some other stuff next week too)





----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Vendredi 14 Juin 2019 09:20:15
Objet: applied: [pve-devel] [PATCH pve-manager 0/4] network api : reload : cleanup

On 6/13/19 3:48 PM, Alexandre Derumier wrote: 
> Remove all dirty check, now handle by ifupdown2 directly. 
> 
> I have also add a check to not reload if openswitch is installed. 
> maybe add a conflict in updown2 package vs openswitch. 
> (reload don't work, and ifup/down can work with ifupdown classic scripts, 
> but it's not well tested and need config format changes) 
> 
> 
> 
> Alexandre Derumier (4): 
> network api : reload : remove ifdown/up hack 
> network api : reload : don't check bridge delete 
> network api : reload : always reload 
> network api : reload : don't allow openswitch at all 
> 
> PVE/API2/Network.pm | 107 ++------------------------------------------ 
> 1 file changed, 3 insertions(+), 104 deletions(-) 
> 

applied, thanks. 

Regarding the OVS stuff, does the checks needs to be that "hard", i.e., 
couldn't I have OVS installed but unused? 
But it's an easy and cheapo check so for now definitively OK for me.. 
I'll try to bump and move the current set of packages out on pvetest 
during start of next week, FYI, should make it a bit easier again - 
and no need to bootstrap anymore :)