[pve-devel] [PATCH docs] Fixed some wording and typos

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 14 07:28:11 CEST 2019


On 6/12/19 3:06 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  pve-installation.adoc   |  2 +-
>  pve-intro.adoc          |  6 +++---
>  pve-network.adoc        | 28 ++++++++++++++--------------
>  pve-package-repos.adoc  |  2 +-
>  qm-pci-passthrough.adoc | 12 ++++++------
>  5 files changed, 25 insertions(+), 25 deletions(-)
> 

applied, with a small fixup (see below). @Aaron, sorry if I get in your
way with your bigger rewrite, but I'd like to have this already in for
the case it needs a bit longer to get your work reviewed in a good manner.

Git should take care of most things anyway, and else it's a good way
to improve merge conflict skills ;P

> diff --git a/pve-installation.adoc b/pve-installation.adoc
> index f15258e..691d236 100644
> --- a/pve-installation.adoc
> +++ b/pve-installation.adoc
> @@ -104,7 +104,7 @@ you can choose disks there. Additionally you can set additional options (see
>  
>  [thumbnail="screenshot/pve-select-location.png", float="left"]
>  
> -The next page just ask for basic configuration options like your
> +The next page just asks for basic configuration options like your
>  location, the time zone and keyboard layout. The location is used to
>  select a download server near you to speed up updates. The installer is
>  usually able to auto detect those settings, so you only need to change
> diff --git a/pve-intro.adoc b/pve-intro.adoc
> index e4a8d99..7b236be 100644
> --- a/pve-intro.adoc
> +++ b/pve-intro.adoc
> @@ -39,7 +39,7 @@ enables you to store the configuration of thousands of virtual
>  machines. By using corosync, these files are replicated in real time
>  on all cluster nodes. The file system stores all data inside a
>  persistent database on disk, nonetheless, a copy of the data resides
> -in RAM which provides a maximum storage size is 30MB - more than
> +in RAM which provides a maximum storage size of 30MB - more than
>  enough for thousands of VMs.
>  +
>  Proxmox VE is the only virtualization platform using this unique
> @@ -145,7 +145,7 @@ Flexible Networking
>  Proxmox VE uses a bridged networking model. All VMs can share one
>  bridge as if virtual network cables from each guest were all plugged
>  into the same switch. For connecting VMs to the outside world, bridges
> -are attached to physical network cards assigned a TCP/IP
> +are attached to physical network cards and assigned a TCP/IP
>  configuration.
>  
>  For further flexibility, VLANs (IEEE 802.1q) and network
> @@ -183,7 +183,7 @@ Open source software also helps to keep your costs low and makes your
>  core infrastructure independent from a single vendor.
>  
>  
> -Your benefit with {pve}
> +Your benefits with {pve}
>  -----------------------

the marker for headlines ('-' in this case) should be aligned with
the headline itself. IIRC, with templates as {pve} it get's corrected
anyway, but else it can result in a build failure, so best to always
do it.




More information about the pve-devel mailing list