[pve-devel] applied: [PATCH v5 manager] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

[Thomas Lamprecht]

On 6/11/19 3:31 PM, Christian Ebner wrote:
> On some occasions e.g. license checking, the manufacturer string in the
> SMBIOS settings edit has to allow characters such as whitespaces.
> https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/
> In principle SMBIOS allows to pass any zero terminated string to the
> corresponding fields in the structure type 1 (System Information).
> 
> By base64 encoding the values clashing of the config is avoided.
> 
> Relies on the corresponding patch to qemu-server to pass parameter verification
> and correct parsing.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> Version 5:
>     * As discussed offline, allow multiline editing of the fields in the UI
> 
>  www/manager6/Parser.js           | 31 +++++++++++++++++++++--------
>  www/manager6/qemu/Smbios1Edit.js | 42 ++++++++++++++++++++++++++++------------
>  2 files changed, 53 insertions(+), 20 deletions(-)
> 

applied, thanks! I followed up with making the panel static declared only,
and actually I'd liked to used the 'defaults' [0] property to set fieldStyle
and xtype for all those textareas, but we do not pass it along in our
InputPanel, from which this extends, and I didn't got it to work by some
quick tries, @Domninik to you have an idea what would be needed to actually
make passing defaults correctly?