[pve-devel] [PATCH manager] change error message related to maxbackups

[Thomas Lamprecht]

On 6/11/19 5:18 PM, Oguz Bektas wrote:
> make the message to be a little more informative, namely mentioning the
> ability to change this option.
> 
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>  PVE/VZDump.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 0a35eea7..0f8572fc 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -780,7 +780,8 @@ sub exec_backup_task {
>  
>  	if ($maxfiles && !$opts->{remove}) {
>  	    my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname);
> -	    die "only $maxfiles backup(s) allowed - please consider to remove old backup files.\n" 
> +	    die "There is a max backup limit of $maxfiles set for this drive.".
> +	    " Please consider changing the limit or deleting old backup(s).\n"
>  		if scalar(@$bklist) >= $maxfiles;
>  	}
>  
> 

not really true.
There's a _storage_ (not drive) wide possible maxfiles limit which can
get overwritten through the CLI or API with the --maxfile parameter of
vzdump, so the original message, while a bit more vague, held actually
more truth, IMO...

We could make it more definitive if we'd know which option limits us,
i.e., the CLI one if set or the storage one else, or better find a wording
which is clearer but also not wrong. Maybe:

> There is a max backup limit of ($maxfiles) enforced by the target storage or the vzdump parameters.".
> Either increase the limit or delete old backup(s).\n"