[pve-devel] applied: [PATCH pve-network 0/2] improvments

[Thomas Lamprecht]

On 6/11/19 9:46 AM, Alexandre DERUMIER wrote:
>>> I have send patches, but I don't have look at PMG currently. (I never have used it to be honest)
>>> (I have only move the network configuration part, and was only used in Network API)
> I have looked in PMG,
> 
> seem that it shouldn't break it (maybe simply need to add a depend on pve-network)
> 
> PVE::INotify::read_file('interfaces') is used here, in network api
> https://git.proxmox.com/?p=pmg-api.git;a=blob;f=PMG/API2/Network.pm;h=b6a58da73a4752c2cba2398028a14e366343de39;hb=HEAD
> 
> adding "use PVE::NetworkConfig"  to register interfaces file should be enough.
> 
> 
> Maybe this Network.pm api could be common too, but they are a difference on" use PMG::RESTEnvironment"

but I'd rather not add that dependency, as the PMG has no use for
SDN itself.. and maybe you want to use pve-cluster in pve-network,
and then PMG would depend (indirectly) on that too, which it currently
does not (its cluster stack is a really simple architecture compared to
PVE >= 2, it has no pmxcfs, simple master-slave architecture)..

We could either:
* see if we keep INotify in pve-common, if we really need we could overwrite,
  or extend it with a INotify "sub-class" in pve-network, did not really
  looked into it, so not sure how reasonable and feasible that is..
* move INotify and keep a copy of it for the PMG separately somewhere
  (pmg-api), not 100% nice but we do not changed this often so it shouldn't
   be to much work to maintain both copies...

what do you think?