[pve-devel] [PATCH ifupdown2] ifup/ifdown vxlan interface on reload

[Thomas Lamprecht]

On 6/6/19 7:24 AM, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---

looks OK for now, I'd wait a bit on upstream commentary as I didn't
plan to bump ifudown2 really soon, so maybe I can just pull the master,
or even the current release, as the last one was almost half a year ago,
so one should probably happen quite soon anyway. Or aren't they
motivated at the current time as of Debian's freeze for Buster?
At least Julien Forint is the DM of the package[0] and the releases
have a almost suspicious high frequency just before the freeze kicked
in ^^

Anyway, I hope I do not hinder you here? I'd try to at least bump it
once for our PVE 6 release (whenever that is) on current master.

[0]: https://tracker.debian.org/pkg/ifupdown2

>  ...wn-up-vxlan-interfaces-when-ifreload_down.patch | 33 ++++++++++++++++++++++
>  debian/patches/series                              |  1 +
>  2 files changed, 34 insertions(+)
>  create mode 100644 debian/patches/extra/0001-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch
> 
> diff --git a/debian/patches/extra/0001-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch b/debian/patches/extra/0001-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch
> new file mode 100644
> index 0000000..a2df043
> --- /dev/null
> +++ b/debian/patches/extra/0001-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch
> @@ -0,0 +1,33 @@
> +From 0eb16c0cae122a69a01acc228067f84bfbb0b6dc Mon Sep 17 00:00:00 2001
> +From: Alexandre Derumier <aderumier at odiso.com>
> +Date: Wed, 5 Jun 2019 14:47:05 +0200
> +Subject: [PATCH] ifreload: down/up vxlan interfaces when
> + ifreload_down_changed=0
> +
> +almost all attributes of vxlan interfaces can't be updated
> +in current kernel (<= 5.2). (including vxlan-id)
> +
> +so when ifreload_down_changed=0, ifreload can't update vxlan.
> +
> +fix: https://github.com/CumulusNetworks/ifupdown2/issues/50
> +Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> +---
> + ifupdown2/ifupdown/ifupdownmain.py | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/ifupdown2/ifupdown/ifupdownmain.py b/ifupdown2/ifupdown/ifupdownmain.py
> +index f520994..f1fd0d7 100644
> +--- a/ifupdown2/ifupdown/ifupdownmain.py
> ++++ b/ifupdown2/ifupdown/ifupdownmain.py
> +@@ -2099,7 +2099,7 @@ class ifupdownMain(ifupdownBase):
> +                                      % (newifaceobjlist[objidx].name,
> +                                         ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind)))
> +                     ifacedownlist.append(newifaceobjlist[objidx].name)
> +-                if not down_changed:
> ++                if not down_changed and ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vxlan':
> +                     continue
> +                 if len(newifaceobjlist) != len(lastifaceobjlist):
> +                     ifacedownlist.append(ifname)
> +-- 
> +2.11.0
> +
> diff --git a/debian/patches/series b/debian/patches/series
> index 5fc2cfc..e1c1032 100644
> --- a/debian/patches/series
> +++ b/debian/patches/series
> @@ -3,3 +3,4 @@ pve/0002-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch
>  pve/0003-add-dummy-mtu-bridgevlanport-modules.patch
>  pve/0004-debian-fixup-networking.service.patch
>  pve/0005-allow-vlan-subinterface-in-a-vlan-aware-bridge.patch
> +extra/0001-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch
>