[pve-devel] applied: [PATCH manager v2 0/4] show osd versions in osd overview

[Dominik Csapak]

On 5/31/19 4:37 PM, Thomas Lamprecht wrote:
> Am 5/31/19 um 12:15 PM schrieb Dominik Csapak:
>> this series add the osd versions in the gui, and highlights outdated
>> ones
>>
>> also fixes the wrong comparison of ceph versions
>>
>> Dominik Csapak (4):
>>    gui: add compare_ceph_versions
>>    gui/ceph: show versions in osd overview
>>    gui: ceph: hide outdated osd line if possible
>>    gui: ceph: fix version comparison
>>
>>   PVE/API2/Ceph/OSD.pm              |  4 ++++
>>   www/manager6/Utils.js             | 32 ++++++++++++++++++++++++++++++++
>>   www/manager6/ceph/OSD.js          | 37 ++++++++++++++++++++++++++++++++++---
>>   www/manager6/ceph/Services.js     |  2 +-
>>   www/manager6/ceph/StatusDetail.js |  7 ++++---
>>   5 files changed, 75 insertions(+), 7 deletions(-)
>>
> 
> applied, with a two main followups:

thanks :)

> 1. replace the rather hardcoded unflexible version handling with
>     one which is a tad more flexible, as it does not cost anything

you are right ofc, altough if the ceph releases get another part, we
have to adapt our code in the backend nonetheless (also since
we release our own packages, this is something we will definitely notice 
;) )

> 2. Removed the font awesome "box" icon for the host OSD version,
>     it's the one we use for CTs, which I really do not want to reuse
>     for something completely differnt, IMO just bad UX, and also I
>     had no idea why a box was chosen in the first place, the commit
>     message does not mention any reasoning either.

mhmm, i put that there for 2 reasons:

1. to indicate that the version on the host is the installed package 
version, not necessarily that of any running service

2. to break up the list of versions to see immediately the
osd versions vs. the host versions, maybe you have a different idea on
how to do this? maybe another icon or text in addition? another column 
altogether?

> 
> 
> thanks!
>