[pve-devel] applied: [PATCH qemu-server] Add a FIXME to the Q35 config to rm audio0 dev

[Thomas Lamprecht]

On 7/24/19 3:57 PM, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> 
> Not sure how everyone feels about this, but maybe a small note like this
> is useful to not forget to remove this when we get the next chance.
> 
>  pve-q35-4.0.cfg | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/pve-q35-4.0.cfg b/pve-q35-4.0.cfg
> index 9a294bd..c931417 100644
> --- a/pve-q35-4.0.cfg
> +++ b/pve-q35-4.0.cfg
> @@ -58,7 +58,9 @@
>    masterbus = "ehci-2.0"
>    firstport = "4"
>  
> -
> +# FIXME: Remove this audio0 device at the next possible time

applied, thanks!

FYI: The semi-official syntax which for denoting such hints I'm using is:

"FIXME: Remove with PVE 7.0"
"FIXME: Remove with next machine type bump to >= 4.1"

so your fit's too, being a bit more specific, if possible, helps naturally,
though. :)


> +#     see: https://pve.proxmox.com/pipermail/pve-devel/2019-July/038417.html
> +#          https://pve.proxmox.com/pipermail/pve-devel/2019-July/038428.html
>  [device "audio0"]
>    driver = "ich9-intel-hda"
>    bus = "pcie.0"
>