[pve-devel] applied: [PATCH installer 1/2] handle bootloader installation errors gracefully

[Thomas Lamprecht]

On 7/23/19 2:52 PM, Fabian Grünbichler wrote:
> by collecting them, but proceeding with the rest of the installation. it
> is possible that only either legacy or EFI boot fails, and even if both
> do, manually fixing the bootloader setup by booting a live CD is very
> often possible.
> 
> still display the error screen at the end if bootloader setup was not
> successful, so that expectations are not set too high..
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> see https://forum.proxmox.com/threads/unable-to-unmount-zfs-after-installation.56144/#post-258894
> for one scenario where this would possibly have been helpful
> 
> best viewed with -w, since most of the changes are adding eval around
> certain blocks ;)
> 
>  proxinstall | 96 +++++++++++++++++++++++++++++++++++------------------
>  1 file changed, 63 insertions(+), 33 deletions(-)
> 
> [...]
> +	    push @$bootloader_err_list, $@ if $@;
> +
> +	    if (scalar(@$bootloader_err_list) > 0) {
> +		$bootloader_err = "bootloader setup errors:\n";
> +		map { $bootloader_err .= "- $_" } @$bootloader_err_list;

IMO, if no mapping is done (or it's side effects are used) a simple

$bootloader_err .= "- $_" for @$bootloader_err_list;

seems a bit more in place, but it works both just fine, so: applied thanks!

> +		warn $bootloader_err;
>  	    }
>  
>  	    syscmd("umount $targetdir/dev");