[pve-devel] applied-series: [PATCH manager v2 0/5] add ceph flag gui

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 23 13:35:03 CEST 2019


On 7/23/19 9:52 AM, Dominik Csapak wrote:
> instead of only setting/unsetting the noout flag, show a window
> with all available flags that the user can set
> 
> changes from v1:
>  * rebase on master
>  * use check_ceph_configured
>  * rename allflags to flags2
>  * better comment for flagmap
>  * better error printing
>  * better set/unset flag check
>  * better map generation
> 
> Dominik Csapak (5):
>   ceph: add GET 'flags2'
>   ceph: add PUT 'flags' api call
>   ceph: set/unset flag: remove unused variable
>   gui: ceph: add a ceph flag EditWindow
>   gui: ceph: convert 'set noout' button to 'set flags'
> 
>  PVE/API2/Ceph.pm         | 117 ++++++++++++++++++++++++++++++++++++++-
>  www/manager6/ceph/OSD.js | 101 +++++++++++++++++++++++++++------
>  2 files changed, 200 insertions(+), 18 deletions(-)
> 

applied series, but currently still on doing some changes regarding
flag/flags2/flag.

Also, a followup like discussed for pulling out the two different used
"get current set flags" assembly and some UI follouwps, one for commiting
the changes in the store (avoids the red triangle in the rows on edit),
a change from "Set Flags" to "Manage Global Flags" and a hack to ensure
the window gets rendered centered (it's alignment is done when the store
is still empty/ the grid not rendered, and then seems off once it is
fully there)




More information about the pve-devel mailing list