[pve-devel] [PATCH manager 2/6] ceph: add GET 'allflags'

[Fabian Grünbichler]

On Tue, Jul 23, 2019 at 07:52:38AM +0200, Thomas Lamprecht wrote:
> On 7/22/19 4:08 PM, Dominik Csapak wrote:
> > we want a GET api call where we return all available flags with
> > description, but the GET 'flags' api call already returns a string
> > and not an array, so we cannot use that
> > 
> > instead, we add a new api call that returns that feature and
> > with e.g. pve 7 we can remove the 'flags' api call and
> > rename 'allflags' to 'flags'
> > 
> > Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> > ---
> > i am not too attached to the name 'allflags' but could not come up
> > with a better one
> > 
> > also could not think of any other possibility than adding a seperate
> > api call besides a breaking api change, but maybe someone has an idea?
> 
> a current drawback we already have (with or without this patch) is that
> while we can set flags by doing a:
> 
> POST: /nodes/NODE/ceph/flags/FLAGNAME
> 
> we have no directory index for it..

maybe (feel free to substitute flag2/... for flag in the path)

GET /nodes/NODE/ceph/flag

index of flag objects with

name
description
current status

similar to /nodes/NODE/qemu or /nodes/NODE/services

GET /nodes/NODE/ceph/flag/FLAGNAME

same, but just for one specific flag?
description could also just be included for this detailed call,
depending on usage on the client side?

POST/DELETE /nodes/NODE/ceph/flag/FLAGNAME

what's currently /nodes/NODE/ceph/flags/FLAGNAME, aliased until 7.x,
with the latter marked as deprecated

GET /nodes/NODE/ceph/flags

deprecated, kept until 7.x for API compat