[pve-devel] [PATCH manager 2/6] ceph: add GET 'allflags'

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 23 07:06:01 CEST 2019


On 7/22/19 4:08 PM, Dominik Csapak wrote:
> we want a GET api call where we return all available flags with
> description, but the GET 'flags' api call already returns a string
> and not an array, so we cannot use that
> 
> instead, we add a new api call that returns that feature and
> with e.g. pve 7 we can remove the 'flags' api call and
> rename 'allflags' to 'flags'
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> i am not too attached to the name 'allflags' but could not come up
> with a better one

Linux syscall style: flags2 ? :)

(underlines that this is really intended to do the same/simlar stuff
in a better way and/or with more possibility)

> 
> also could not think of any other possibility than adding a seperate
> api call besides a breaking api change, but maybe someone has an idea?

I mean, you could just return all flags as a string and then split them
up in the frontend again.. But, if we're sure about that the new call allows
us better handling I'm not against it... 




More information about the pve-devel mailing list