[pve-devel] [PATCH manager 0/2 v3] Add GUI for audio device

[Thomas Lamprecht]

On 7/19/19 3:32 PM, Aaron Lauterer wrote:
> This series adds the GUI part for the audio device.
> 
> It's a partial v3 to [0] (the GUI part).
> 
> The option for the audio backend is fixed to `spice` in accordance with
> the latest patch to qemu-server [1].
> 
> [0]: https://pve.proxmox.com/pipermail/pve-devel/2019-July/038273.html
> [1]: https://pve.proxmox.com/pipermail/pve-devel/2019-July/038333.html

from a quick look: looks OK.

Single things I'm not yet fully sure (sorry) is UX, i.e., would it make sense
to have this in the Display field when selecting spice? I mean:

Pros
 + Makes only sense to have if one has spice
 + Most people using spice probably want this too, so shortcut to get to it
   (if I'd even have it default to on/add)

Cons
 - Could seem a bit strange to have audio in a display component
 - if more audio stuff comes we'd need to split it up again, or have the
   possibility to add spice audio two different ways (non-ideal)

@Tim, @Domninik: what do you think?