[pve-devel] [PATCH container v2 5/5] setup getty: ensure the getty.target is not masked

[Fabian Grünbichler]

On Thu, Jul 18, 2019 at 06:37:02PM +0200, Thomas Lamprecht wrote:
> some distro templates have this masked by default, it makes sense to
> always ensure that it can work, a CT admin can still prevent this by
> using the .pve-ignore.$file mechanism.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> 
> changes v1 -> v2:
> * as a single call site is left just do it directly there, no need for an extra
>   method..
> 
>  src/PVE/LXC/Setup/Base.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> index 06c0089..b0f2747 100644
> --- a/src/PVE/LXC/Setup/Base.pm
> +++ b/src/PVE/LXC/Setup/Base.pm
> @@ -228,6 +228,8 @@ sub setup_container_getty_service {
>  	    $self->ct_symlink("$sd_dir/$service", "$getty_target_fn/$tty_service");
>  	}
>      }
> +
> +    $self->ct_unlink("/etc/systemd/system/getty.target");

a comment here, like

# ensure getty.target is not masked

would be great to make this obvious.

with this and the other change

Acked-by for the whole series ;)

>  }
>  
>  sub setup_systemd_networkd {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel