[pve-devel] [PATCH manager 4/4] gui: ceph dashboard: improve version hints

[Dominik Csapak]

show the difference between a service where the host has outdated
packages, and where only the service runs an outdated version and only
needs to restart

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/ceph/Services.js | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/www/manager6/ceph/Services.js b/www/manager6/ceph/Services.js
index f53fc5a2..1e987bf8 100644
--- a/www/manager6/ceph/Services.js
+++ b/www/manager6/ceph/Services.js
@@ -206,13 +206,23 @@ Ext.define('PVE.ceph.Services', {
 		    result.statuses.push(gettext('Version') + ": " + result.version);
 
 		    if (result.version != maxversion) {
-			if (result.health > healthstates.HEALTH_OLD) {
-			    result.health = healthstates.HEALTH_OLD;
+			if (metadata.version[result.host] === maxversion) {
+			    if (result.health > healthstates.HEALTH_OLD) {
+				result.health = healthstates.HEALTH_OLD;
+			    }
+			    result.messages.push(
+				PVE.Utils.get_ceph_icon_html('HEALTH_OLD', true) +
+				gettext('Not Current Version, please restart')
+			    );
+			} else {
+			    if (result.health > healthstates.HEALTH_UPGRADE) {
+				result.health = healthstates.HEALTH_UPGRADE;
+			    }
+			    result.messages.push(
+				PVE.Utils.get_ceph_icon_html('HEALTH_UPGRADE', true) +
+				gettext('Not Current Version, please upgrade and restart')
+			    );
 			}
-			result.messages.push(
-			    PVE.Utils.get_ceph_icon_html('HEALTH_OLD', true) +
-			    gettext('Not Current Version, please upgrade')
-			);
 		    }
 		}
 
-- 
2.20.1