[pve-devel] [PATCH manager] gui: dc/Options: make migration network selector editable
Thomas Lamprecht
t.lamprecht at proxmox.com
Wed Jul 17 14:57:19 CEST 2019
On 7/17/19 2:46 PM, Dominik Csapak wrote:
> this fixes 3 things:
> * one can enter subnets that are not configured
> (does not make sense most of the time, but it can be)
> * if a migration network is set where there is no configured
> ip exists, it shows again when editing
> * a user can delete it again without pressing backspace/del
one needs to press those keys too here, if editable ;)
Not sure, IMO makes no sense, this must be configured else it cannot
be used anyway, I want to avoid allowing wrong ones here as then the
migration breaks...
It's not like this is a multistep wizard were one needs to repeat a
lot of inputs when (s)he sees that the desired network is not yet
configured, simply configure it and re-open that simple dialog?
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> www/manager6/dc/OptionView.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
> index 3974e59e..72c09aa8 100644
> --- a/www/manager6/dc/OptionView.js
> +++ b/www/manager6/dc/OptionView.js
> @@ -100,6 +100,7 @@ Ext.define('PVE.dc.OptionView', {
> fieldLabel: gettext('Network'),
> value: null,
> emptyText: Proxmox.Utils.defaultText,
> + editable: true,
> autoSelect: false,
> skipEmptyText: true
> }]
>
More information about the pve-devel
mailing list