[pve-devel] applied: [PATCH v2 cluster] API: correctly propagate $@ with nested locks

[Thomas Lamprecht]

On 7/16/19 3:43 PM, Fabian Grünbichler wrote:
> PVE::Cluster::cfs_lock_file sets $@ and returns undef for all errors,
> including when $code dies. PVE::Tools::lock_file runs $code inside an
> eval as well, so just setting $@ is not enough when nesting these two
> types of locks.
> 
> re-die with the inner error to actually propagate error messages and
> fail instead of proceeding. this triggered (probably among other cases)
> when attempting to join an existing cluster without specifying all
> needed links.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 

applied to master and stable-5, thanks!