[pve-devel] [PATCH manager 1/2] pve5to6: check for ceph-volume osds

[Fabian Grünbichler]

On Mon, Jul 15, 2019 at 11:26:17AM +0200, Thomas Lamprecht wrote:
> Am 7/15/19 um 11:17 AM schrieb Dominik Csapak:
> >>
> >> and the case where some OSDs did not got yet "upgraded" to ceph-volume/nautilus
> >> but a new one was created cannot happen?
> >>
> > no it should not as the upgrade guide says
> > -----8<----
> > During the upgrade from Luminous to Nautilus it will not be possible to create a new OSD using a Luminous ceph-osd daemon after the monitors have been upgraded to Nautilus. Avoid adding or replacing any OSDs while the upgrade is in progress.
> > ----->8----
> > 
> > so if one has upgraded, the check only shows the not yet upgraded luminous osds, and only after the user should add new osds
> > 
> > 
> 
> ah, so not "no" just because the upgrade guide says it should not be done,
> does not means that one may not can or at least try to do (and cause some
> harm).. But I'd guess that is not too important, hits people who did not
> read our various notices about ceph-volume and did not used the checlist
> helper..
> 
> Something else, now if I have 5 (old) OSDs I run 5to6 and see that, then
> I upgrade some (not all) and then the 5to6 reports nothing at all, or?
> IMO, that's really not ideal if that's the case, seems brittle and allows
> people with many OSDs to forget some more easily, the will notice it sooner
> or later, but we have the 5to6 script for the exact reason to let them know
> sooner.  

yes, but then again, this only hits people that don't follow the upgrade
guidelines (which give the command to scan and activate ALL OSDs, and
gives help on how to manually scan indiviual OSDs in case something goes
wrong and OSDs are not coming up again via ceph-volume after a reboot..)