[pve-devel] [PATCH v4 lvm] fix #2184: filter lvs from guests

[Thomas Lamprecht]

On 7/12/19 1:05 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>  ...0002-fix-2184-filter-lvs-from-guests.patch | 27 +++++++++++++++++++
>  ...03-enable-issue_discards-by-default.patch} |  0
>  patchdir/series                               |  3 ++-
>  3 files changed, 29 insertions(+), 1 deletion(-)
>  create mode 100644 patchdir/0002-fix-2184-filter-lvs-from-guests.patch
>  rename patchdir/{0002-enable-issue_discards-by-default.patch => 0003-enable-issue_discards-by-default.patch} (100%)

now applies and works -> applied, thanks! ;)

Tried to add the info in your new comment that this is for
VGs not named "pve" but the result was not perfect.


> 
> diff --git a/patchdir/0002-fix-2184-filter-lvs-from-guests.patch b/patchdir/0002-fix-2184-filter-lvs-from-guests.patch
> new file mode 100644
> index 0000000..cf72538
> --- /dev/null
> +++ b/patchdir/0002-fix-2184-filter-lvs-from-guests.patch
> @@ -0,0 +1,27 @@
> +From a91e2f0d45b3f11d4cf25f769e5daeb0f8a83fb7 Mon Sep 17 00:00:00 2001
> +From: Oguz Bektas <o.bektas at proxmox.com>
> +Date: Fri, 12 Jul 2019 13:00:15 +0200
> +Subject: [PATCH] fix #2184: filter lvs from guests
> +
> +Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> +---
> + conf/example.conf.in | 3 ++-
> + 1 file changed, 2 insertions(+), 1 deletion(-)
> +
> +diff --git a/conf/example.conf.in b/conf/example.conf.in
> +index 009a442ed..78073569a 100644
> +--- a/conf/example.conf.in
> ++++ b/conf/example.conf.in
> +@@ -125,7 +125,8 @@ devices {
> + 	# Run vgscan after changing the filter to regenerate the cache.
> + 	# 
> + 	# Do not scan ZFS zvols (to avoid problems on ZFS zvols snapshots)
> +-	global_filter = [ "r|/dev/zd.*|", "r|/dev/mapper/pve-.*|" ]
> ++	# Also do not scan LVM disks from guests
> ++	global_filter = [ "r|/dev/zd.*|", "r|/dev/mapper/pve-.*|" "r|/dev/mapper/.*-vm--[0-9]+--disk--[0-9]+|"]
> + 
> + 	# Example
> + 	# Accept every block device:
> +-- 
> +2.20.1
> +
> diff --git a/patchdir/0002-enable-issue_discards-by-default.patch b/patchdir/0003-enable-issue_discards-by-default.patch
> similarity index 100%
> rename from patchdir/0002-enable-issue_discards-by-default.patch
> rename to patchdir/0003-enable-issue_discards-by-default.patch
> diff --git a/patchdir/series b/patchdir/series
> index cb43ddc..b63618d 100644
> --- a/patchdir/series
> +++ b/patchdir/series
> @@ -1,4 +1,5 @@
>  0001-filter-zvols-and-PVE-VG-by-default.patch
> -0002-enable-issue_discards-by-default.patch
> +0002-fix-2184-filter-lvs-from-guests.patch
> +0003-enable-issue_discards-by-default.patch
>  0006-disable-init-scripts.patch
>  udev-do-not-overwrite-ID_MODEL-in-69-dm-lvm-metad.rules.patch
>