[pve-devel] [PATCH manager 2/2] improve default console behaviour

[Dominik Csapak]

On 7/12/19 1:40 PM, Thomas Lamprecht wrote:
> On 7/12/19 1:33 PM, Dominik Csapak wrote:
>> instead of instantly defaulting to novnc when the chosen
>> default is not available, try the other (better variant)
>> before falling back to novnc
>>
>> e.g. having no default set is equivalent to having it set
>> to xtermjs, and having a vm with spice then previously
>> defaulted to novnc, now to spice (the reverse is also true)
>>
> 
> not sure about the reverse? I.e., novnc is more similar in what
> you see than xterm.js for a virtual machine at least..
> I.e., serial terminal (where it's not guaranteed that a TTY is
> listening on it) vs the normal "screen". Could be OK, but not to
> sure..?

it is also not guaranteed that there is output on the screen
(e.g. with gpu passthrough/vgpus/vga=none etc.)
but i get where you're coming from

two possible even better ways (but more work):
1. do not have a 'default' but an ordered list of defaults
2. specify with the vm what you want (which either the user has to 
select in the wizard or gets autoselected based on the cluster default 
and the vm hardware)

if you want, i can remove the spice -> xtermjs logic for now and
we can discuss it sometime?

> 
> Could I also suggest the following commit subject:
> ui: improve console fallback logic if default is not available
> 

sounds better ;)