[pve-devel] [PATCH storage] Diskmanage: add flag for encrypted osds

[Fabian Grünbichler]

On Fri, Jul 12, 2019 at 09:04:08AM +0200, Dominik Csapak wrote:
> On 7/11/19 4:37 PM, Fabian Grünbichler wrote:
> > assuming the different approach compared to the bluestore variable is
> > to avoid false negatives for OSDs encrypted in some other way, this
> > looks good to me.
> 
> yes, i did not want to return 'encrypted => 0' if i am not sure
> that it is not encrypted any other way
> 
> but thinking again about this, in the gui we will probably
> either show 'osd (encrypted)' or its own column
> with encrypted yes/no so the distinction that we do not know
> does not really make sense...
> 
> should i send a v2 where the logic is like bluestore?

yes, if we don't want tristate on the consumer side it would make the
code more uniform..