[pve-devel] [PATCH v2 widget-toolkit 1/2] KVComboBox: add setComboItems function

[Oguz Bektas]

On Thu, Jul 11, 2019 at 03:00:07PM +0200, Dominik Csapak wrote:
> is there a 2/2 also ?
2/2 was the manager patch, sorry for confusion
> 
> looks good except the one nit inline
> 
> On 7/11/19 2:54 PM, Oguz Bektas wrote:
> > this allows to change the comboItems of a KVComboBox on the run
> > 
> > Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> > ---
> > 
> > no changes, added for convenience
> > 
> >   form/KVComboBox.js | 7 +++++++
> >   1 file changed, 7 insertions(+)
> > 
> > diff --git a/form/KVComboBox.js b/form/KVComboBox.js
> > index 0970fcf..5e76f6f 100644
> > --- a/form/KVComboBox.js
> > +++ b/form/KVComboBox.js
> > @@ -71,5 +71,12 @@ Ext.define('Proxmox.form.KVComboBox', {
> >   	}
> >   	me.callParent();
> > +    },
> > +
> > +    setComboItems: function(items) {
> > +	var me = this;
> > +
> > +	me.getStore().setData(items);
> >       }
> > +
> 
> this empty line seems unnecessary
> 
> >   });
> > 
> 
>