[pve-devel] applied: [PATCH manager 2/2] gui: ceph osd: rewrite osd panel and add scrub button

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 11 14:24:40 CEST 2019


On 7/10/19 3:13 PM, Dominik Csapak wrote:
> this rewrite of the osd panel converts it to a static declaration of
> the layout with a controller/viewmodel logic
> 
> while doing this, add icons to buttons, and add a scrub/deep scrub entry
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> i guess it would be easiest to review the result and not the diff,
> since it is simply a big rewrite of the whole component..
> 

applied, thanks! Followed up with re-adding the "Used %" column,
removing  the viewmodel notify call (not necessary, and in debug
mode this can result into uncaught exceptions due to nested calls
to it by the scheduler).

Also reworked the columns of the OSD and Pool panel in general, but
that work was not really connected to your refactoring (it was already
ugly before ;)





More information about the pve-devel mailing list