[pve-devel] applied-series: [PATCH installer v2 0/2] create unique identifiers on install

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 9 19:44:52 CEST 2019


On 7/9/19 6:09 PM, Stoiko Ivanov wrote:
> while looking into #1603 I misread and focussed on /etc/hostid, instead of
> /etc/machine-id. Upon closer inspection the problem is similar for both of them:
> Our installer shipped one version of the file for both ids, while it should
> create them uniquely for the system.
> 
> Addionally the /etc/hostid was not shipped in the installed system, which
> could lead to unimportable pools if it gets generated later on.
> 
> v1->v2
> * Thomas suggested off-list to take a look at `systemd-id128 new` as a way
>   to create a truly new random id (not depending on the magic with kvm UUIDs and
>   dbus
> 
> Tested by installing twice successfully and comparing ids
> 
> Stoiko Ivanov (2):
>   fix #1603: create a new and unique machine-id
>   copy /etc/hostid from installer root to target
> 
>  proxinstall | 5 +++++
>  1 file changed, 5 insertions(+)
> 

applied series, thanks!




More information about the pve-devel mailing list